-
Notifications
You must be signed in to change notification settings - Fork 161
Feat; collector dequeue job #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kobzol
merged 7 commits into
rust-lang:master
from
Jamesbarford:feat/collector-dequeue-job
Jul 31, 2025
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
57fb0f5
Most of the scaffolding for dequeuing a job from a collector
Jamesbarford 296f585
Created `AddCollector` command line option and created more tests for…
Jamesbarford 168260b
Pr Feedback; Remove un-needed items from RETURNING, don't update benc…
Jamesbarford 1c200c6
Pr feedback; remove the auto string macros for status and use the str…
Jamesbarford a4c2ddc
Pr Feedback; remove collector version of CollectorConfig and un-neede…
Jamesbarford a094fa3
Pr Feedback; create index on status-target-benchmark_set
Jamesbarford 52bfe1f
Pr Feedback; remove `IF NOT EXISTS` from adding collector_name column
Jamesbarford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| use chrono::{DateTime, Utc}; | ||
| use database::BenchmarkSet; | ||
|
|
||
| use super::target::Target; | ||
|
|
||
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct CollectorConfig { | ||
Jamesbarford marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| name: String, | ||
| target: Target, | ||
| benchmark_set: BenchmarkSet, | ||
| is_active: bool, | ||
| last_heartbeat_at: DateTime<Utc>, | ||
| date_added: DateTime<Utc>, | ||
| } | ||
|
|
||
| impl CollectorConfig { | ||
| pub fn name(&self) -> &str { | ||
| &self.name | ||
| } | ||
|
|
||
| pub fn target(&self) -> &Target { | ||
| &self.target | ||
| } | ||
|
|
||
| pub fn benchmark_set(&self) -> &BenchmarkSet { | ||
| &self.benchmark_set | ||
| } | ||
|
|
||
| pub fn is_active(&self) -> bool { | ||
| self.is_active | ||
| } | ||
|
|
||
| pub fn last_heartbeat_at(&self) -> DateTime<Utc> { | ||
| self.last_heartbeat_at | ||
| } | ||
|
|
||
| pub fn date_added(&self) -> DateTime<Utc> { | ||
| self.date_added | ||
| } | ||
| } | ||
|
|
||
| impl From<database::CollectorConfig> for CollectorConfig { | ||
| fn from(value: database::CollectorConfig) -> Self { | ||
| CollectorConfig { | ||
| name: value.name().into(), | ||
| target: Target::from_db_target(value.target()), | ||
| benchmark_set: value.benchmark_set().clone(), | ||
| is_active: value.is_active(), | ||
| last_heartbeat_at: value.last_heartbeat_at(), | ||
| date_added: value.date_added(), | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.