Do not exit website if there is no data #2218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It’s annoying when testing the UI (e.g. when using the perf.rlo remote endpoint even locally), right? |
|
Yeah, well it is especially annoying when testing the new job queue system, because it is supposed to fill data from the master/release commit list, and works fine even without any existing local benchmarks. So there's no need to exit. |
Kobzol
force-pushed
the
site-empty-results
branch
from
cc07698 to
d7b43d7
Compare
|
Worst case you also add a |
|
Would |
Not really, I don't want it to terminate :D I just want to run the website locally even if there is no data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was super annoying for local tests. Let's see if CI is fine with it.