Skip to content

767: triage; fetch pr titles #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2020
Merged

767: triage; fetch pr titles #809

merged 4 commits into from
Dec 12, 2020

Conversation

Horki
Copy link
Contributor

@Horki Horki commented Dec 8, 2020 •
edited by Mark-Simulacrum
Loading

  • fixed typo prefereable into preferable
  • msg: format ex.: "Fix SGX CI, take 3 #79797"

Mark-Simulacrum
Mark-Simulacrum reviewed Dec 8, 2020
View reviewed changes
@Horki
Copy link
Contributor Author

Horki commented Dec 8, 2020

@Mark-Simulacrum In case of 401, or other error, it returns an empty string; fetching GITHUB_TOKEN via os.getenv

@Horki
Copy link
Contributor Author

Horki commented Dec 12, 2020

@Mark-Simulacrum please review, and add suggestions

@Horki Horki mentioned this pull request Dec 12, 2020
Closed
@Mark-Simulacrum
Copy link
Member

Thanks! The CI failure is due to upstream problems with a rustdoc bug, and this looks good to me, so merging.

@Mark-Simulacrum Mark-Simulacrum merged commit d9bc242 into rust-lang:master Dec 12, 2020
@Horki Horki deleted the 767_pr_title branch December 12, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Horki @Mark-Simulacrum