Skip to content

767: triage; fetch pr titles #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2020
Merged

767: triage; fetch pr titles #809

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5482946
767: triage; fetch pr titles
Horki Dec 8, 2020
97c7b65
767: add token from env, and exception handler
Horki Dec 8, 2020
7d27c54
Merge branch 'master' into 767_pr_title
Horki Dec 12, 2020
6e8f5b2
767: check for GITHUB_TOKEN
Horki Dec 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions triage/weekly_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ def eprint(*args, **kwargs):
'mixed': [],
}

pr_titles = dict()


def get_username():
usernames = {'mackendy': 'ecstaticmorse', 'joshua': 'jyn514'}
Expand Down Expand Up @@ -95,7 +97,7 @@ def relative_change(expected, actual):
def log_change(expected, actual):
'''Returns `ln(actual / expected)`

This is prefereable to percentage change because it scales equally for
This is preferable to percentage change because it scales equally for
positive or negative changes. This means that the order of the arguments
only affects the sign of the output

Expand Down Expand Up @@ -172,6 +174,17 @@ def gh_link(pr):
return f'https://github.com/rust-lang/rust/issues/{pr}'


def gh_pr_title(pr):
if pr in pr_titles:
return pr_titles.get(pr)

url = f'https://api.github.com/repos/rust-lang/rust/pulls/{pr}'
with urllib.request.urlopen(url) as f:
data = json.loads(f.read())
pr_titles[pr] = data['title']
return pr_titles[pr]


def compare_link(start, end, stat):
return f'https://perf.rust-lang.org/compare.html?start={start}&end={end}&stat={stat.value}'

Expand All @@ -180,8 +193,9 @@ def write_section(res, *changes):
pr = res['b']['pr']
start = res['a']['commit']
end = res['b']['commit']
title = gh_pr_title(pr)

msg = f'[#{pr}]({gh_link(pr)})'
msg = f'{title} [#{pr}]({gh_link(pr)})'

for change in changes:
msg += '\n- '
Expand Down