Skip to content

use llvm.roundeven on arm #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

use llvm.roundeven on arm #1906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions crates/core_arch/src/arm_shared/neon/generated.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58256,10 +58256,9 @@ pub fn vrhaddq_u32(a: uint32x4_t, b: uint32x4_t) -> uint32x4_t {
pub fn vrndn_f16(a: float16x4_t) -> float16x4_t {
unsafe extern "unadjusted" {
#[cfg_attr(
any(target_arch = "aarch64", target_arch = "arm64ec"),
any(target_arch = "aarch64", target_arch = "arm64ec", target_arch = "arm"),
link_name = "llvm.roundeven.v4f16"
)]
#[cfg_attr(target_arch = "arm", link_name = "llvm.arm.neon.vrintn.v4f16")]
fn _vrndn_f16(a: float16x4_t) -> float16x4_t;
}
unsafe { _vrndn_f16(a) }
Expand All @@ -58279,10 +58278,9 @@ pub fn vrndn_f16(a: float16x4_t) -> float16x4_t {
pub fn vrndnq_f16(a: float16x8_t) -> float16x8_t {
unsafe extern "unadjusted" {
#[cfg_attr(
any(target_arch = "aarch64", target_arch = "arm64ec"),
any(target_arch = "aarch64", target_arch = "arm64ec", target_arch = "arm"),
link_name = "llvm.roundeven.v8f16"
)]
#[cfg_attr(target_arch = "arm", link_name = "llvm.arm.neon.vrintn.v8f16")]
fn _vrndnq_f16(a: float16x8_t) -> float16x8_t;
}
unsafe { _vrndnq_f16(a) }
Expand All @@ -58308,10 +58306,9 @@ pub fn vrndnq_f16(a: float16x8_t) -> float16x8_t {
pub fn vrndn_f32(a: float32x2_t) -> float32x2_t {
unsafe extern "unadjusted" {
#[cfg_attr(
any(target_arch = "aarch64", target_arch = "arm64ec"),
any(target_arch = "aarch64", target_arch = "arm64ec", target_arch = "arm"),
link_name = "llvm.roundeven.v2f32"
)]
#[cfg_attr(target_arch = "arm", link_name = "llvm.arm.neon.vrintn.v2f32")]
fn _vrndn_f32(a: float32x2_t) -> float32x2_t;
}
unsafe { _vrndn_f32(a) }
Expand All @@ -58337,10 +58334,9 @@ pub fn vrndn_f32(a: float32x2_t) -> float32x2_t {
pub fn vrndnq_f32(a: float32x4_t) -> float32x4_t {
unsafe extern "unadjusted" {
#[cfg_attr(
any(target_arch = "aarch64", target_arch = "arm64ec"),
any(target_arch = "aarch64", target_arch = "arm64ec", target_arch = "arm"),
link_name = "llvm.roundeven.v4f32"
)]
#[cfg_attr(target_arch = "arm", link_name = "llvm.arm.neon.vrintn.v4f32")]
fn _vrndnq_f32(a: float32x4_t) -> float32x4_t;
}
unsafe { _vrndnq_f32(a) }
Expand Down
8 changes: 2 additions & 6 deletions crates/stdarch-gen-arm/spec/neon/arm_shared.spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2486,9 +2486,7 @@ intrinsics:
name: "llvm.frinn.{neon_type}"
links:
- link: "llvm.roundeven.{neon_type}"
arch: aarch64,arm64ec
- link: "llvm.arm.neon.vrintn.{neon_type}"
arch: arm
arch: aarch64,arm64ec,arm

- name: "vrndn{neon_type.no}"
doc: "Floating-point round to integral, to nearest with ties to even"
Expand All @@ -2510,9 +2508,7 @@ intrinsics:
name: "llvm.frinn.{neon_type}"
links:
- link: "llvm.roundeven.{neon_type}"
arch: aarch64,arm64ec
- link: "llvm.arm.neon.vrintn.{neon_type}"
arch: arm
arch: aarch64,arm64ec,arm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the arch field is required, even though we now use the same code for all targets that this tool supports, so technically the cfg's could be dropped.


- name: "vqadd{neon_type.no}"
doc: Saturating add
Expand Down