Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented May 29, 2025

This should make it much easier to figure out a GitHub username from Zulip name, and Zulip name from a GitHub username.

Suggested here: #t-compiler/contrib-private > Nominating mati865 and madsmtm @ 💬.

I know that the code of the Zulip integration is... not great. I just copy-pasted stuff around for this, but after this PR (and after rust-lang/rust-forge#853, which shuffles some Zulip docs and mentions Zulip DM commands), I want to do the following:

  • Split the zulip.rs file into multiple modules
  • Rewrite the command handling using e.g. clap (or something similar), to both remove the manual parsing and provide automatically generated error messages for users
  • Use an actual Zulip API client struct, rather than copy pasting loading of the Zulip API token from the environment and Zulip API error handling all over the place.
  • Document this (and the previous whoami command in the Forge)

@Kobzol Kobzol requested a review from Urgau May 29, 2025 09:54
@Urgau
Copy link
Member

Urgau commented May 29, 2025

I want to do the following

100% on board, as always feel free to assign me; also happy to discuss some details before hand

Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks okay to me.

It's unfortunate that it's anything but trivial, but it's only for a command, so let's go.

@Kobzol Kobzol added this pull request to the merge queue May 29, 2025
Merged via the queue into rust-lang:master with commit 1b98d07 May 29, 2025
3 checks passed
@Kobzol Kobzol deleted the whois-cmd branch May 29, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants