Split github.rs file into multiple smaller sub-modules#2298
Open
Urgau wants to merge 4 commits intorust-lang:masterfrom
Open
Split github.rs file into multiple smaller sub-modules#2298Urgau wants to merge 4 commits intorust-lang:masterfrom
github.rs file into multiple smaller sub-modules#2298Urgau wants to merge 4 commits intorust-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
github.rsfile, where all of our models and calls to GitHub APIs lives has grown organically over time without any sense of logic or order.It currently sits at more than 3500 lines longs.
This PR split it into more manageable sub-modules:
client.rs: forGithubClientevent.rs: models for the webhooksissue.rs: model and API call regardingIssueissue_query.rs: everything related toIssuesQuerytraitissue_repository.rs: model and API call regardingIssueRepositoryrepos.rs: mainly API calls for GitHub's/reposendpointrepos/issue_with_comments.rs: models and API call for our `/gh-comments/ endpointrepos/issue_with_comments.rs: models and API call for our `/gh-comments/ endpointrepository.rs: model and API call regardingRepositoryutils.rs: some utils methods and modelsgithub.rsnow only contains some reexport.