Skip to content

Split github.rs file into multiple smaller sub-modules #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Urgau wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Split github.rs file into multiple smaller sub-modules #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
885d2d3
Split `github.rs` file into multiple smaller sub-modules
Urgau Feb 21, 2026
9a3cea6
Continue splitting `github.rs`
Urgau Feb 21, 2026
a306dcf
Add missing import to split-ted github modules
Urgau Feb 21, 2026
6d5169b
Fix visibility of some fields and methods
Urgau Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/actions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pub enum QueryKind {
pub struct QueryMap<'a> {
pub name: &'a str,
pub kind: QueryKind,
pub query: Arc<dyn github::IssuesQuery + Send + Sync>,
pub query: Arc<dyn github::issue_query::IssuesQuery + Send + Sync>,
}

#[derive(Debug, serde::Serialize)]
Expand Down
100 changes: 51 additions & 49 deletions src/agenda.rs
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 4 additions & 5 deletions src/gh_comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,16 @@ use hyper::{
header::{CACHE_CONTROL, CONTENT_SECURITY_POLICY, CONTENT_TYPE},
};

use crate::github::GitHubIssueStateReason;
use crate::{
cache,
github::{
github::issue_with_comments::{
GitHubGraphQlComment, GitHubGraphQlReactionGroup, GitHubGraphQlReviewThreadComment,
GitHubIssueState, GitHubIssueWithComments, GitHubReviewState,
GitHubIssueState, GitHubIssueStateReason, GitHubIssueWithComments, GitHubReviewState,
GitHubSimplifiedAuthor,
},
};
use crate::{
errors::AppError,
github::GitHubSimplifiedAuthor,
handlers::Context,
utils::{immutable_headers, is_repo_autorized},
};
Expand Down Expand Up @@ -727,7 +726,7 @@ fn write_reaction_groups_as_html(
continue;
}

use crate::github::GitHubGraphQlReactionContent::*;
use crate::github::issue_with_comments::GitHubGraphQlReactionContent::*;
let emoji = match reaction_group.content {
ThumbsUp => "👍",
ThumbsDown => "👎",
Expand Down
Loading