Unify logic for showing all Project Members and generating individual pages for each person #2226
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
reviewed
Nov 4, 2025
… pages for each person
Kobzol
force-pushed
the
more-people-pages
branch
from
2ade541 to
d4d1e10
Compare
|
Yeah, it's a bit of a mess, because we (ab)use marker teams also for things that should just be normal teams, currently. This is more of a hotfix, to ensure that people that are on the All Members page actually have a profile page too. Fixed CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found at https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/Including.20every.20member.20of.20the.20Rust.20Project.20on.20a.20single.20page/with/553666213.
We were not generating enough person profile pages. In particular, not all people on the "All Project Members" page had their profile page, which was not ideal, as we were linking to it.
I wonder if we should do this in a different way, and "gather" people that we link to in the other pages, and only generate pages for those.
Let me know what you think.