-
-
Notifications
You must be signed in to change notification settings - Fork 183
uefi: Add safe protocol wrapper for EFI_ATA_PASS_THRU_PROTOCOL #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
phip1611
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Left a few remarks
phip1611
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there!
|
Like with NVMe, I just rebased this MR and split it into more / smaller commits. One note on the integration test: |
|
Added a couple minor comments, otherwise lgtm |
|
@nicholasbishop I hope I have addressed all of your comments. The |
|
I fixed the CI in #1631 |
Update Latest API discussions
Implemented a safe API wrapper for
EFI_ATA_PASS_THRU_PROTOCOL[1d3de7f0-0807-424f-aa69-11a54e19a46f].Added an integration-test for it.
This contains a copy of the AlignedBuffer commit from #1589.
This uses the iterator/mutable design I suggested here: #1589 (comment) where the iter method only captures the protocol (
AtaPassThru) immutably, but requires you to use the produced element (AtaDevice) in a mutable way for meaningful methods like execute_command.This closes #244
Checklist