-
Notifications
You must be signed in to change notification settings - Fork 127
workspace: update to Rust edition 2024 #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bfae2dc
to
7f6433e
Compare
@roypat Seems like the failed "buildkite/kvm-ci/pr/clippy-riscv64" was a random CI failure? |
yes, that looks spurious :) |
} else { | ||
32 | ||
} | ||
if x > 0 { x as usize } else { 32 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a few of the formatting changes already made it into this commit (e.g. also the import reformatting). :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it was the only one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mh, seems like this one (and the import changes) are still in the first commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, sorry let me recheck. Perhaps I missed something when doing the rebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now its fixed :D
46814c4
to
ca5d807
Compare
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
I'll rebase this onto #337 before merging. Aye? |
88e3987
to
f5a1f9d
Compare
I dont think they conflict, so having this one going in first shouldn't be a problem :) |
Signed-off-by: Philipp Schuster <[email protected]> On-behalf-of: SAP [email protected]
f5a1f9d
to
d0ce32f
Compare
Summary of the PR
Modernize the code base by using the latest Rust edition. Supersedes #331 as #331 seems to have no activity.
Steps to Undraft
merge and rebase onto build(deps): bump rust-vmm-ci fromc3ef897
to0b1cb86
#337Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.