Skip to content

Conversation

phip1611
Copy link
Contributor

@phip1611 phip1611 commented Aug 11, 2025

Summary of the PR

Modernize the code base by using the latest Rust edition. Supersedes #331 as #331 seems to have no activity.

Steps to Undraft

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@phip1611 phip1611 force-pushed the rust-edition-2024 branch 3 times, most recently from bfae2dc to 7f6433e Compare August 12, 2025 06:05
@phip1611
Copy link
Contributor Author

@roypat Seems like the failed "buildkite/kvm-ci/pr/clippy-riscv64" was a random CI failure?

@roypat
Copy link
Member

roypat commented Aug 12, 2025

@roypat Seems like the failed "buildkite/kvm-ci/pr/clippy-riscv64" was a random CI failure?

yes, that looks spurious :)

} else {
32
}
if x > 0 { x as usize } else { 32 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a few of the formatting changes already made it into this commit (e.g. also the import reformatting). :/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it was the only one :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, seems like this one (and the import changes) are still in the first commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, sorry let me recheck. Perhaps I missed something when doing the rebase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now its fixed :D

@phip1611 phip1611 force-pushed the rust-edition-2024 branch 2 times, most recently from 46814c4 to ca5d807 Compare August 12, 2025 07:44
@phip1611 phip1611 changed the title workspace: update to Rust edition 2024 + prepare 0.24 workspace: update to Rust edition 2024 Aug 12, 2025
@phip1611 phip1611 requested a review from roypat August 12, 2025 07:46
Signed-off-by: Philipp Schuster <[email protected]>
On-behalf-of: SAP [email protected]
@phip1611
Copy link
Contributor Author

phip1611 commented Aug 12, 2025

I'll rebase this onto #337 before merging. Aye?

@phip1611 phip1611 marked this pull request as draft August 12, 2025 11:24
@roypat
Copy link
Member

roypat commented Aug 12, 2025

I'll rebase this onto #337 before merging. Aye?

I dont think they conflict, so having this one going in first shouldn't be a problem :)

@phip1611 phip1611 marked this pull request as ready for review August 12, 2025 11:36
Signed-off-by: Philipp Schuster <[email protected]>
On-behalf-of: SAP [email protected]
@roypat roypat merged commit d42632f into rust-vmm:main Aug 12, 2025
39 checks passed
@roypat roypat mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants