Use cargo-all-features for our CI #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, on multi-crate workspaces, this test run does precisely nothing. Signed-off-by: Patrick Roy <[email protected]>
roypat
requested review from
andreeaflorescu,
lauralt,
sameo and
ShadowCurse
as code owners
|
Note that this can deal with mutually exclusive features: https://crates.io/crates/cargo-all-features#options |
ShadowCurse
previously approved these changes
Sep 30, 2025
|
@roypat great! thanks for doing this! LGTM, but should we just swap the last 2 patches, I mean first update the container image, then use |
This ensures tests, binaries, benchmarks, examples and libraries are all build-tested, instead of just the default targets. Signed-off-by: Patrick Roy <[email protected]>
We already run `cargo build` with `RUSTFlAGS=-Dwarnings`, so also running `cargo check` with the same arguments, on the same architectures, and with the same rustflags gains us nothing. Signed-off-by: Patrick Roy <[email protected]>
--libs --benches and co are already implies by --all-targets. Signed-off-by: Patrick Roy <[email protected]>
Ah, yes, done! I also swapped the two commits about dropping the |
ShadowCurse
previously approved these changes
Oct 1, 2025
pick up container that has cargo-all-features installed. Signed-off-by: Patrick Roy <[email protected]>
Ensure that every permutation of feature flags is both build-tested, and has their unit-tests ran. The unit-testing part can be reverted to `--all-features` at some point, once we have made sure that all our cargo features are actually additive. Signed-off-by: Patrick Roy <[email protected]>
stefano-garzarella
approved these changes
Oct 1, 2025
ShadowCurse
approved these changes
Oct 1, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Use cargo-all-features in our CI, to ensure that all feature combinations are tested. Closes #152.
The first 4 commits are fixes / cleanups, the last one actually enables cargo-all-features. Needs rust-vmm/rust-vmm-container#139 first.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.