Skip to content

Use cargo-all-features for our CI #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 1, 2025
Merged

Use cargo-all-features for our CI #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c05329a
fix(ci): pass --workspace to build test
roypat Sep 29, 2025
3fc6228
ci: add --all-targets to build test
roypat Sep 29, 2025
7c25d08
ci: drop check-warnings test
roypat Sep 29, 2025
704cab9
ci(clippy): drop redundant arguments
roypat Sep 29, 2025
0970888
chore: bump container version
roypat Sep 30, 2025
d9d0792
ci: convert build and test steps to use cargo-all-features
roypat Sep 29, 2025
8f57a23
Merge branch 'main' into all-features
roypat Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/autogenerate_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@

# This represents the version of the rust-vmm-container used
# for running the tests.
CONTAINER_VERSION = "gf26de2f"
CONTAINER_VERSION = "g5447a4e"
# The suffix suggests that the dev image with `v{N}-riscv` tag is not to be
# confused with real `riscv64` image (it's actually a `x86_64` image with
# `qemu-system-riscv64` installed), since AWS yet has `riscv64` machines
Expand Down
21 changes: 6 additions & 15 deletions .buildkite/test_description.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"tests": [
{
"test_name": "build-gnu",
"command": "RUSTFLAGS=\"-D warnings\" cargo build --release",
"command": "RUSTFLAGS=\"-D warnings\" cargo all-features build --release --workspace --all-targets",
"platform": [
"x86_64",
"aarch64",
Expand All @@ -11,7 +11,7 @@
},
{
"test_name": "build-musl",
"command": "RUSTFLAGS=\"-D warnings\" cargo build --release --target {target_platform}-unknown-linux-musl",
"command": "RUSTFLAGS=\"-D warnings\" cargo all-features build --release --target {target_platform}-unknown-linux-musl --workspace --all-targets",
"platform": [
"x86_64",
"aarch64"
Expand Down Expand Up @@ -39,7 +39,7 @@
},
{
"test_name": "unittests-musl",
"command": "cargo test --all-features --workspace --target {target_platform}-unknown-linux-musl",
"command": "cargo all-features test --workspace --target {target_platform}-unknown-linux-musl",
"platform": [
"x86_64",
"aarch64"
Expand All @@ -50,7 +50,7 @@
},
{
"test_name": "unittests-gnu-release",
"command": "cargo test --release --all-features --workspace",
"command": "cargo all-features test --release --workspace",
"platform": [
"x86_64",
"aarch64",
Expand All @@ -62,7 +62,7 @@
},
{
"test_name": "unittests-musl-release",
"command": "cargo test --release --all-features --workspace --target {target_platform}-unknown-linux-musl",
"command": "cargo all-features test --release --workspace --target {target_platform}-unknown-linux-musl",
"platform": [
"x86_64",
"aarch64"
Expand All @@ -73,16 +73,7 @@
},
{
"test_name": "clippy",
"command": "cargo clippy --workspace --bins --examples --benches --all-features --all-targets -- -D warnings -D clippy::undocumented_unsafe_blocks",
"platform": [
"x86_64",
"aarch64",
"riscv64"
]
},
{
"test_name": "check-warnings",
"command": "RUSTFLAGS=\"-D warnings\" cargo check --all-targets --all-features --workspace",
"command": "cargo clippy --workspace --all-features --all-targets -- -D warnings -D clippy::undocumented_unsafe_blocks",
"platform": [
"x86_64",
"aarch64",
Expand Down