Skip to content

Conversation

albertz
Copy link
Member

@albertz albertz commented Sep 2, 2021

No description provided.

@albertz
Copy link
Member Author

albertz commented Sep 2, 2021

test_attention_no_encoder_dependency fails:

    line: checks += [dyn_size_ext.get_runtime_sanity_check_op()]
    locals:
      checks = <local> [<tf.Operation 'output/rec/prev__accum_att_weights/runtime_sanity_check/Assert/Assert' type=Assert>, <tf.Operation 'output/rec/prev__accum_att_weights/runtime_sanity_check/Assert_1/Assert' type=Assert>, <tf.Operation 'output/rec/prev__accum_att_weights/runtime_sanity_check/Assert_2/Assert' type=A...
      dyn_size_ext = <local> Data(name='time:var:extern_data:data:dyn_size', dtype='int32', beam=SearchBeam(name='output/prev:output', beam_size=4), batch_shape_meta=[B])
      dyn_size_ext.get_runtime_sanity_check_op = <local> <bound method Data.get_runtime_sanity_check_op of Data(name='time:var:extern_data:data:dyn_size', dtype='int32', beam=SearchBeam(name='output/prev:output', beam_size=4), batch_shape_meta=[B])>
  File "/home/runner/work/returnn/returnn/returnn/tf/util/data.py", line 1366, in Data.get_runtime_sanity_check_op
    line: batch_dim_via_info = self.get_batch_dim()
    locals:
      batch_dim_via_info = <not found>
      self = <local> Data(name='time:var:extern_data:data:dyn_size', dtype='int32', beam=SearchBeam(name='output/prev:output', beam_size=4), batch_shape_meta=[B])
      self.get_batch_dim = <local> <bound method Data.get_batch_dim of Data(name='time:var:extern_data:data:dyn_size', dtype='int32', beam=SearchBeam(name='output/prev:output', beam_size=4), batch_shape_meta=[B])>
  File "/home/runner/work/returnn/returnn/returnn/tf/util/data.py", line 3045, in Data.get_batch_dim
    line: assert self.batch.beam == self.beam
    locals:
      self = <local> Data(name='time:var:extern_data:data:dyn_size', dtype='int32', beam=SearchBeam(name='output/prev:output', beam_size=4), batch_shape_meta=[B])
      self.batch = <local> BatchInfo{B}
      self.batch.beam = <local> None
      self.beam = <local> SearchBeam(name='output/prev:output', beam_size=4)
AssertionError: 

This should have been fixed by better dim tag batch logic (#613).

@albertz albertz force-pushed the albert-tmp-extend-runtime-sanity-check branch from 1656907 to d2df9c2 Compare September 2, 2021 13:48
@albertz albertz force-pushed the albert-tmp-extend-runtime-sanity-check branch from d2df9c2 to cbd515e Compare September 2, 2021 21:23
@albertz albertz closed this Sep 2, 2021
@albertz albertz deleted the albert-tmp-extend-runtime-sanity-check branch September 2, 2021 21:25
@albertz albertz restored the albert-tmp-extend-runtime-sanity-check branch September 2, 2021 21:25
@albertz albertz reopened this Sep 2, 2021
@albertz albertz merged commit 87919e8 into master Sep 2, 2021
@albertz albertz deleted the albert-tmp-extend-runtime-sanity-check branch September 2, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant