TypeScript Package

[PaulRBerg]

See also the associated PR in the docs repo: sablier-labs/docs#308

• Closes Tentative spec for TypeScript package #21
• Closes Remove Skale testnet and Berachain Artio #24
• Closes Duplicate "entries" in Airdrops v1.3.0 deployment for SablierMerkleFactory on Abstract chain #25
• Closes Lockup v1.1.2 periphery deployments are incorrectly indexed as v1.1.1 #27
• Closes Add Legacy addresses sdk#8
• Closes Add "infura" and "alchemy" getters in the "Chain" type sdk#7

[PaulRBerg]

The PR is finally ready for review, @sablier-labs/evm!

We should hop on a call to discuss next week. Feel free to book a time in my Calendly.

[smol-ninja]

Well done. I have booked for Tuesday afternoon.

[smol-ninja]

Since, its very difficult to post comments on the diff, I will post some of them here (which requires discussion) and the rest can be seen in my PR: #41.

Its not a good idea to emit the entire periphery deployment under airdrops repo. Between SABLIER_V2_BATCH and SABLIER_V2_MERKLE_STREAMER_FACTORY, only the latter should be a part of the airdrops release whereas SABLIER_V2_BATCH should be part of the lockup release. We can fix it by refactoring as the following:

    core: {
      [manifest.core.SABLIER_V2_COMPTROLLER]: "0x17Ec73692F0aDf7E7C554822FBEAACB4BE781762",
      [manifest.core.SABLIER_V2_LOCKUP_DYNAMIC]: ["0xf390cE6f54e4dc7C5A5f7f8689062b7591F7111d", 161_612_601],
      [manifest.core.SABLIER_V2_LOCKUP_LINEAR]: ["0xFDD9d122B451F549f48c4942c6fa6646D849e8C1", 161_611_816],
      [manifest.core.SABLIER_V2_NFT_DESCRIPTOR]: "0x2fb103fC853b2F5022a840091ab1cDf5172E7cfa",
      [manifest.periphery.SABLIER_V2_BATCH]: "0xAFd1434296e29a0711E24014656158055F00784c",
    },
    periphery: {
      [manifest.periphery.SABLIER_V2_MERKLE_STREAMER_FACTORY]: [
        "0x237400eF5a41886a75B0e036228221Df075b3B80",
        161_026_555,
      ],

If you agree with this, lmk and I will be happy to make this change in my review PR.

[PaulRBerg]

Its not a good idea to emit the entire periphery deployment under airdrops repo

Ah, great observation — I don't agree with the fix, though.

What we should do is convert the LockupV1 release into a Standard release. I'll handle it on my branch directly.

edit: wait, I don't think I see any bug here. We are only looking for the factories:

deployments/src/releases/airdrops/v1.1/deployments.ts

Lines 10 to 18 in 5838dff

	function filterByTestnet(isTestnet: boolean): Sablier.Deployment[] {
	return _.filter(deployments, (deployment) => {
	const chain = chainsQueries.get(deployment.chainId);
	return (
	chain?.isTestnet === isTestnet &&
	_.some(deployment.periphery, { name: manifest.SABLIER_V2_MERKLE_STREAMER_FACTORY })
	);
	});
	}

But maybe I misunderstood your point, @smol-ninja. Could you confirm?

[smol-ninja]

You are right. I misread that. All good now. Thanks.

[PaulRBerg]

I was almost ready to merge this PR, but I realized that what I built is so different from what this repo was originally meant to be that I decided to put my work into a new repo called SDK:

https://github.com/sablier-labs/sdk

The package will be available on npm as sablier 🤩

---

Besides that, there is another benefit to creating a new repo (SDK) and archiving this repo (deployments):

Backward-compatibility with the links we have shared over time, e.g. in the docs, we use the main branch as a re instead of a particular git commit ref. See an example here).