Skip to content

chore(appset/templates): remove annotations from GitHub and GitLab templates#252

Merged
saidsef merged 6 commits intomainfrom
project-parameters-annotations
Jan 17, 2026
Merged

chore(appset/templates): remove annotations from GitHub and GitLab templates#252
saidsef merged 6 commits intomainfrom
project-parameters-annotations

Conversation

@saidsef
Copy link
Copy Markdown
Owner

@saidsef saidsef commented Jan 17, 2026

This pull request updates the Helm chart for ArgoCD ApplicationSets with new features, dependency version bumps, and changes to annotation handling. The most significant updates include raising the minimum required versions for Kubernetes and ArgoCD, adding support for destinationServiceAccounts in project values, and refactoring how annotations are managed in the chart templates.

Dependency and requirements updates:

  • Increased minimum required Kubernetes version to 1.31 and ArgoCD ApplicationSet Controller to v2.13, and updated Helm minimum version to v3.10. [1] [2]
  • Chart version bumped from 0.16.1 to 0.17.1.
  • Updated README to reflect new minimum requirements. [1] [2]

Features and values:

  • Added support for destinationServiceAccounts in project values and templates, allowing specification of service accounts per destination. [1] [2] [3]

Annotation handling and template refactoring:

  • Moved certain annotation references to use global chart values for annotations, streamlining configuration.

  • Removed several hardcoded annotations related to ArgoCD Image Updater and ApplicationSet refresh from github-pr.yml and gitlab-mr.yml templates, relying instead on global annotations. [1] [2]

  • chore(appset/templates): remove annotations from GitHub and GitLab templates

  • chore(projects/values): add default empty list for destinationServiceAccounts spec

  • chore(docs): update prerequisites for Kubernetes, ArgoCD, and HELM versions

  • chore(chart): update version and kubeVersion, refine annotations in Chart.yaml

  • Resolves: chore: Update Helm chart dependencies and streamline annotation configuration #253

@saidsef saidsef added enhancement New feature or request security Security labels Jan 17, 2026
@saidsef saidsef self-assigned this Jan 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 17, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-actions[bot]
github-actions bot previously approved these changes Jan 17, 2026
@saidsef saidsef merged commit 8ccb27d into main Jan 17, 2026
9 checks passed
@saidsef saidsef deleted the project-parameters-annotations branch January 17, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request security Security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Update Helm chart dependencies and streamline annotation configuration

2 participants