chore(appset/templates): remove annotations from GitHub and GitLab templates#252
Merged
chore(appset/templates): remove annotations from GitHub and GitLab templates#252
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Helm chart for ArgoCD ApplicationSets with new features, dependency version bumps, and changes to annotation handling. The most significant updates include raising the minimum required versions for Kubernetes and ArgoCD, adding support for
destinationServiceAccountsin project values, and refactoring how annotations are managed in the chart templates.Dependency and requirements updates:
0.16.1to0.17.1.Features and values:
destinationServiceAccountsin project values and templates, allowing specification of service accounts per destination. [1] [2] [3]Annotation handling and template refactoring:
Moved certain annotation references to use global chart values for annotations, streamlining configuration.
Removed several hardcoded annotations related to ArgoCD Image Updater and ApplicationSet refresh from
github-pr.ymlandgitlab-mr.ymltemplates, relying instead on global annotations. [1] [2]chore(appset/templates): remove annotations from GitHub and GitLab templates
chore(projects/values): add default empty list for destinationServiceAccounts spec
chore(docs): update prerequisites for Kubernetes, ArgoCD, and HELM versions
chore(chart): update version and kubeVersion, refine annotations in Chart.yaml
Resolves: chore: Update Helm chart dependencies and streamline annotation configuration #253