Annotation Feature : Past and Future Date fields#18
Open
anshubala1 wants to merge 2 commits intomasterfrom
Open
Annotation Feature : Past and Future Date fields#18anshubala1 wants to merge 2 commits intomasterfrom
anshubala1 wants to merge 2 commits intomasterfrom
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): anshu-bala <a***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
| class FutureDateFieldValidator<FailureT> : ValidatorAnnotation1<LocalDate, FailureT> { | ||
| override fun validate( | ||
| field: Field, | ||
| value: LocalDate, |
Collaborator
There was a problem hiding this comment.
We should support the deprecated Java 8 Date also as most of core and Connect APIs still use it.
|
|
||
| @Retention(AnnotationRetention.RUNTIME) | ||
| @Target(AnnotationTarget.FIELD) | ||
| annotation class FutureDateField(val failureKey: String) |
Collaborator
There was a problem hiding this comment.
IMO, we can drop Field suffix and call it @FutureDate itself
overfullstack
force-pushed
the
master
branch
from
6548b68 to
77e2591
Compare
overfullstack
force-pushed
the
master
branch
from
b777921 to
1685d48
Compare
overfullstack
force-pushed
the
master
branch
from
e4776e1 to
58210d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains Annotation feature for Vador framework.
This will add 2 annotations.
Added tests for the same.