Skip to content

Conversation

anoopcs9
Copy link
Collaborator

The parameters for the base shaman url that was used to determine the chacra repository link did not have status=ready resulting in invalid chacra urls as part of the json response. Make sure that we fetch with status=ready so as to create repo files with valid base url.

The parameters for the base shaman url that was used to determine the
chacra repository link did not have `status=ready` resulting in invalid
chacra urls as part of the json response. Make sure that we fetch with
`status=ready` so as to create repo files with valid base url.

Signed-off-by: Anoop C S <[email protected]>
Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@spuiuk spuiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mergify mergify bot merged commit 53799e0 into samba-in-kubernetes:master Aug 12, 2025
41 checks passed
@anoopcs9 anoopcs9 deleted the fix-shaman-url-params branch August 12, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants