ctdb: improve hostname lookup for ctdb nodes #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhernandez
reviewed
Sep 2, 2024
avanthakkar
force-pushed
the
fix-hostname-lookup
branch
from
ac89c7d to
bfe4844
Compare
Fixes: samba-in-kubernetes#136 Signed-off-by: Avan Thakkar <[email protected]>
avanthakkar
force-pushed
the
fix-hostname-lookup
branch
from
bfe4844 to
7445362
Compare
xhernandez
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the hostname lookup function to support multi-homed systems and mixed IPv4/IPv6 environments by using
socket.getaddrinfo.This change removes the previous loopback filtering hack, now explicitly filtering loopback addresses and prioritizing IPv4 addresses where available. Improved error handling for cases with no valid IP addresses found.
Fixes: #136