Skip to content

Conversation

anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented Feb 14, 2025

          @avanthakkar Why are we not returning IPv6 address from here? What special case are we dealing with additional `ipv6_address`?

Originally posted by @anoopcs9 in #146 (comment)

Copy link
Collaborator

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlogistonjohn
Copy link
Collaborator

I had assumed the way the code was previously was that it was designed to prefer any ipv4 address over an ipv6 address. @avanthakkar is that not the case? - I see you approved already, and so I guess that is not important - but I would like to confirm this clearly.

@anoopcs9
Copy link
Collaborator Author

I had assumed the way the code was previously was that it was designed to prefer any ipv4 address over an ipv6 address.

Ah..I see that this preference is clearly mentioned in the description for #137. I was searching for any indications in commit message and there wasn't any.

So this change is no longer relevant.

@avanthakkar
Copy link
Collaborator

I had assumed the way the code was previously was that it was designed to prefer any ipv4 address over an ipv6 address.

Ah..I see that this preference is clearly mentioned in the description for #137. I was searching for any indications in commit message and there wasn't any.

So this change is no longer relevant.

ah yes, my bad! I missed to take this point into consideration

@anoopcs9 anoopcs9 closed this Feb 17, 2025
@anoopcs9 anoopcs9 deleted the simplify-ctdb-lookup-hostname branch February 17, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants