Skip to content

commands: Simplify _lookup_hostname() in ctdb module #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

commands: Simplify _lookup_hostname() in ctdb module #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions sambacc/commands/ctdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,26 +269,15 @@ def _lookup_hostname(hostname: str) -> str:
family=socket.AF_UNSPEC,
type=socket.SOCK_STREAM,
)
ipv6_address = None

for family, _, _, _, sockaddr in addrinfo:
if family == socket.AF_INET:
if family == socket.AF_INET or family == socket.AF_INET6:
ip_address = sockaddr[0]
assert isinstance(ip_address, str)
if ip_address.startswith("127."):
if ip_address.startswith("127.") or ip_address == "::1":
continue
return ip_address

if family == socket.AF_INET6 and ipv6_address is None:
ip_address = sockaddr[0]
assert isinstance(ip_address, str)
if ip_address == "::1":
continue
ipv6_address = ip_address

if ipv6_address:
return ipv6_address

raise RuntimeError(
f"No valid IP address found for hostname '{hostname}'."
)
Expand Down
Loading