Skip to content

Conversation

@phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented Mar 11, 2025

Depends on: https://gitlab.com/samba-team/samba/-/merge_requests/4002

When the ctdb ceph rados mutex helper tool supports the -R option to
skip registering the helper as a ceph service - do so.
This avoids confusion on the ceph side as the helper will act more like
a typical rados client than something on the level of an OSD or MDS.

Add a new samba specifics flag that indicates that the
ctdb_mutex_ceph_rados_helper program supports the -R option to skip
registering the helper as a ceph service.

Signed-off-by: John Mulligan <[email protected]>
When the ctdb ceph rados mutex helper tool supports the -R option to
skip registering the helper as a ceph service - do so.
This avoids confusion on the ceph side as the helper will act more like
a typical rados client than something on the level of an OSD or MDS.

Signed-off-by: John Mulligan <[email protected]>
@phlogistonjohn phlogistonjohn marked this pull request as ready for review March 17, 2025 14:08
Copy link
Collaborator

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To consume early, should we try to build quay.io/samba.org/samba-server:devbuilds-centos-amd64 with ctdb_rados_mutex_skip_reg using SAMBA_SPECIFICS from GitHub workflow for samba-container?

@mergify mergify bot merged commit 8c5f50a into samba-in-kubernetes:master Mar 17, 2025
9 checks passed
@phlogistonjohn
Copy link
Collaborator Author

Yeah, that it is what I am looking into next.

@phlogistonjohn phlogistonjohn deleted the jjm-skip-mutex-helper-reg branch March 27, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants