Skip to content

ctdb: skip mutex helper service registration #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

ctdb: skip mutex helper service registration #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0e12be
sambacc: add a specifics flag for mutex helper registration option
phlogistonjohn Mar 11, 2025
5d1dde8
commands: when possible skip ceph service registration for mutex helper
phlogistonjohn Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sambacc/commands/ctdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,10 @@ def ctdb_rados_mutex(ctx: Context) -> None:
# optional namespace argument
if namespace:
cmd = cmd["-n", namespace]
skip_reg_option = samba_cmds.ctdb_rados_mutex_skip_registration_opt()
if skip_reg_option:
# skip registring ctdb rados mutex helper as a service
cmd = cmd[skip_reg_option]
_logger.debug("executing command: %r", cmd)
samba_cmds.execute(cmd) # replaces process

Expand Down
7 changes: 7 additions & 0 deletions sambacc/samba_cmds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
# Known flags for SAMBA_SPECIFICS env variable
_DAEMON_CLI_STDOUT_OPT: str = "daemon_cli_debug_output"
_CTDB_LEADER_ADMIN_CMD: str = "ctdb_leader_admin_command"
_CTDB_RADOS_MUTEX_SKIP_REG: str = "ctdb_rados_mutex_skip_reg"


def get_samba_specifics() -> typing.Set[str]:
Expand Down Expand Up @@ -61,6 +62,12 @@ def ctdb_leader_admin_cmd() -> str:
return leader_cmd


def ctdb_rados_mutex_skip_registration_opt() -> str:
if _CTDB_RADOS_MUTEX_SKIP_REG in get_samba_specifics():
return "-R" # skip registration option
return ""


def set_global_prefix(lst: list[str]) -> None:
_GLOBAL_PREFIX[:] = lst

Expand Down
Loading