Add basic ODJ support #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Joiner object had an overloaded join_source method that took a source kind enum and argument. There were also various add_<x>_source methods that add_source would call. Remove the add_source method and replace all uses with calls to add_<x>_source methods that are clearer, document-able, and more typing friendly. Signed-off-by: John Mulligan <[email protected]>
Add initial support for joining samba to active directory using Offline Domain Join (ODJ) blobs. Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Signed-off-by: John Mulligan <[email protected]>
Found with a new version of flake8 and is blocking the CI. Signed-off-by: John Mulligan <[email protected]>
|
@spuiuk @anoopcs9 @avanthakkar PTAL |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for joining to AD using Offline Domain Join blobs.