build image on ubuntu with docker #28
Conversation
There was a problem hiding this comment.
I'm wondering why it didn't fail with our recent PRs. AFAICT, the runner is already on 24.04. Is that due to some major docker version upgrade these days? If so, can you please paste the error (just out of curiosity)?
There was a problem hiding this comment.
I tried to reproduce this (as error), but now I only just get it as warn:
go: download go1.23 for linux/amd64: toolchain not available
Originally, it happened on a newly installed ubuntu 24.04 vm, but afterwards I upgrade the vm so maybe it fixed the problem.
There was a problem hiding this comment.
I tried to reproduce this (as error), but now I only just get it as warn:
go: download go1.23 for linux/amd64: toolchain not available
Ah..I think I know why.
Go Toolchains where introduced with 1.21 and they follow a particular naming format. Go toolchain names has some details.
Ok, in that case I think it is wise to mention 1.23.0 to get rid of the warning.
There was a problem hiding this comment.
Still, I don't know why is was an error on a newly installed ubuntu vm, but just a warn now. Sigh...
I'm good to go with the change once the commit message is fixed. |
When running 'docker build' over ubuntu 24.04 (docker version 27.5.1) it fails to build code due to missing release-number in version string of 'go.mod'. Add explicit zero. Signed-off-by: Shachar Sharon <[email protected]>
When building with docker over ubuntu 22.04 it emits warning: require 'AS' keyword instead of lowercase 'as'. Signed-off-by: Shachar Sharon <[email protected]>
synarete
force-pushed
the
ss-build-image-on-ubuntu-with-docker
branch
from
33a638b to
77fb4d4
Compare
Done |
2 participants
Fixes for ubuntu22.04, docker 27.5.1