Skip to content

build image on ubuntu with docker #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

build image on ubuntu with docker #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e4e7e
build: use 'go 1.23.0' in go.mod
synarete Jul 20, 2025
77fb4d4
dockefile: use 'AS' keyword
synarete Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ARG COMMIT_ID="(unset)"
ARG ARCH=""

# Build smbmetrics
FROM docker.io/golang:1.24 as builder
FROM docker.io/golang:1.24 AS builder

WORKDIR /workspace
# Copy the Go Modules manifests
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why it didn't fail with our recent PRs. AFAICT, the runner is already on 24.04. Is that due to some major docker version upgrade these days? If so, can you please paste the error (just out of curiosity)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce this (as error), but now I only just get it as warn:

go: download go1.23 for linux/amd64: toolchain not available

Originally, it happened on a newly installed ubuntu 24.04 vm, but afterwards I upgrade the vm so maybe it fixed the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce this (as error), but now I only just get it as warn:

go: download go1.23 for linux/amd64: toolchain not available

Ah..I think I know why.

Go Toolchains where introduced with 1.21 and they follow a particular naming format. Go toolchain names has some details.

Ok, in that case I think it is wise to mention 1.23.0 to get rid of the warning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, I don't know why is was an error on a newly installed ubuntu vm, but just a warn now. Sigh...

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/samba-in-kubernetes/smbmetrics

go 1.23
go 1.23.0

require (
github.com/go-logr/logr v1.2.3
Expand Down
Loading