Merged
Conversation
- Change DEFAULT_ALIGN_BY from "bounds" to "visual-center-y" - Centralize all defaults in constants.ts (add DEFAULT_DENSITY_AWARE, DEFAULT_CROP_TO_CONTENT) - Use shared constants in useLogoSoup and Storybook stories - Update README to reflect new default
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DEFAULT_ALIGN_BYfrom"bounds"to"visual-center-y", so logos are vertically aligned by visual weight out of the box.Also centralizes all prop defaults into
constants.ts(addsDEFAULT_DENSITY_AWARE,DEFAULT_CROP_TO_CONTENT) and references them from bothuseLogoSoupand Storybook stories.