Use older upload-artifact on GHE

[SuperSandro2000]

Tested on an internal project

[github-actions]

Merging this branch will not change overall coverage

Impacted Packages	Coverage Δ	🤖
github.com/sapcc/go-makefile-maker/internal/core	0.00% (ø)
github.com/sapcc/go-makefile-maker/internal/ghworkflow	0.00% (ø)

---

Coverage by file

Changed files (no unit tests)

Changed File	Coverage Δ	Total	Covered	Missed	🤖
github.com/sapcc/go-makefile-maker/internal/core/constants.go	0.00% (ø)	3 (+3)	0	3 (+3)
github.com/sapcc/go-makefile-maker/internal/ghworkflow/workflow_ci.go	0.00% (ø)	0	0	0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

[abhijith-darshan]

how about adding a parameter to maker yaml for retention-days so that if specified it can generate something like below?

It would save some resources on GHE especially considering the amount of Renovate PRs that get open and re-run due to rebase on merge to default branch? These results likely will not change from the actual code merge on main.

      - name: Archive code coverage results
        uses: actions/upload-artifact@v2
        with:
          name: code-coverage
          path: build/cover.out
          retention-days: 7
          if-no-files-found: ignore

[majewsky]

how about adding a parameter to maker yaml for retention-days

I'm already frustrated with the absurd amount of configuration options that we had to add over time, so I want to avoid that if possible. If retention is a problem on GHE, then we should set the shorter retention based on if hostName != "github.com" or something like that.

[SuperSandro2000]

how about adding a parameter to maker yaml for retention-days so that if specified it can generate something like below?

It would save some resources on GHE especially considering the amount of Renovate PRs that get open and re-run due to rebase on merge to default branch? These results likely will not change from the actual code merge on main.

      - name: Archive code coverage results
        uses: actions/upload-artifact@v2
        with:
          name: code-coverage
          path: build/cover.out
          retention-days: 7
          if-no-files-found: ignore

If the artifact is garbage collected, then PRs fail to generate coverage. The artifact is usually not even 1 MB big, so it shouldn't really be an issue.