Skip to content

Add cloudoperators as a SAPCC project, Document license and make license-headers configurable#397

Merged
SuperSandro2000 merged 4 commits intomainfrom
cloudoperators-fixes
Oct 23, 2025
Merged

Add cloudoperators as a SAPCC project, Document license and make license-headers configurable#397
SuperSandro2000 merged 4 commits intomainfrom
cloudoperators-fixes

Conversation

@SuperSandro2000
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cloudoperators to the list of recognized SAPCC projects, documents the license configuration options in the README, and makes license header generation and dependency checking configurable rather than hardcoded for SAP projects.

Key Changes:

  • Made license header generation and dependency license checking opt-in via configuration
  • Added cloudoperators organization to the SAP project detection logic
  • Enhanced documentation for license-related configuration options

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
main.go Added support for github.com/ prefix (without https) in URL validation
internal/makefile/makefile.go Refactored license checks to be configurable via License.AddHeaders and License.CheckDependencies options
internal/core/config.go Added new configuration fields for license options and included cloudoperators in SAP project detection
README.md Added comprehensive documentation for the new license configuration section and cleaned up workflow examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SuperSandro2000 SuperSandro2000 force-pushed the cloudoperators-fixes branch 2 times, most recently from cbda478 to e76c786 Compare October 22, 2025 15:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/go-makefile-maker 0.00% (ø)
github.com/sapcc/go-makefile-maker/internal/core 0.00% (ø)
github.com/sapcc/go-makefile-maker/internal/makefile 7.69% (-0.14%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/go-makefile-maker/internal/core/config.go 0.00% (ø) 40 0 40
github.com/sapcc/go-makefile-maker/internal/makefile/makefile.go 0.00% (ø) 209 (+6) 0 209 (+6)
github.com/sapcc/go-makefile-maker/main.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@SuperSandro2000 SuperSandro2000 merged commit 2272183 into main Oct 23, 2025
8 checks passed
@SuperSandro2000 SuperSandro2000 deleted the cloudoperators-fixes branch October 23, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants