Skip to content

Commit 9f98c8d

Browse files
authored
Merge pull request kubernetes#2076 from dashpole/test_resource_metrics
Move test plan to its own section in kubelet resource metric KEP
2 parents abdd1ea + 394fe46 commit 9f98c8d

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

keps/sig-node/kubelet-resource-metrics-endpoint.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ status: implementable
3838
- [Results](#results-1)
3939
- [Alternatives Considered](#alternatives-considered)
4040
- [gRPC API](#grpc-api)
41+
- [Test Plan](#test-plan)
4142
- [Graduation Criteria](#graduation-criteria)
4243
- [Implementation History](#implementation-history)
4344
<!-- /toc -->
@@ -206,17 +207,23 @@ service ResourceMetrics {
206207
}
207208
```
208209

210+
### Test Plan
211+
212+
Test the new endpoint with a node-e2e test similar to the current summary API test.
213+
Testgrid: https://k8s-testgrid.appspot.com/sig-node-kubelet#node-kubelet-features-master&include-filter-by-regex=ResourceMetricsAPI
214+
209215
## Graduation Criteria
210216

211217
Alpha:
212218

213-
- [ ] Implement the kubelet resource metrics endpoint as described above
214-
- [ ] Test the new endpoint with a node-e2e test similar to the current summary API test
219+
- [X] Implement the kubelet resource metrics endpoint as described above
220+
221+
Beta:
222+
215223
- [ ] Modify the metrics server to consume the kubelet resource metrics endpoint 3 releases after it is added to the kubelet
216224

217-
Beta/GA:
225+
GA:
218226

219-
- [ ] Determine whether a transition to OpenMetrics format is required, and make those changes if necessary
220227
- [ ] Add node-e2e test to the node conformance tests
221228

222229
## Implementation History

0 commit comments

Comments
 (0)