Move treeMatch into QuoteMatcher
#17236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
changed the title
treeMatch into QuoteMatcher
smarter
approved these changes
May 24, 2023
| (pat, Nil) | ||
|
|
||
| val (pat1, typeHoles) = extractTypeHoles(pattern) | ||
| def exprMatch(scrutinee: Tree, pattern: Tree)(using Context): Option[Tuple] = { |
There was a problem hiding this comment.
what's the advantage of splitting treeMatch like this? It seems we end up with quite a few lines duplicated.
There was a problem hiding this comment.
No sure anymore.
There was a problem hiding this comment.
I refactored the code to only keep treeMatch as before. But added some optimizations to avoid using the TypeMap when it is not going to do anything.
nicolasstucki
force-pushed
the
move-treeMatch-into-QuoteMatcher
branch
from
0acb329 to
c5e40ea
Compare
Now we do not use use the TypeMap if there is no type to map. We also do not create the type map if there are no expression that may contain types that need mapping.
nicolasstucki
force-pushed
the
move-treeMatch-into-QuoteMatcher
branch
from
c5e40ea to
aad8475
Compare
smarter
approved these changes
May 24, 2023
Kordyjan
added a commit
that referenced
this pull request
Nov 17, 2023
Backports #17236 to the LTS branch. PR submitted by the release tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.