Skip to content

Conversation

@KacperFKorban
Copy link
Member

[skip ci]

@KacperFKorban KacperFKorban marked this pull request as ready for review October 17, 2024 15:53
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must add a listing of this page to the sidebar

https://github.com/scala/scala3/blob/main/docs/sidebar.yml

otherwise the content seems good

@KacperFKorban
Copy link
Member Author

@bishabosha and what is the procedure syncing these docs with scala-lang site? Should I create a separate PR there?

@bishabosha
Copy link
Member

bishabosha commented Oct 18, 2024

There's supposed to be an automated PR to generate the stable docs when 3.6.0 is released,
Otherwise the PR is to the stable documentation branch on this repo, and then a bot publishes it

@KacperFKorban
Copy link
Member Author

@bishabosha I didn't fully understand the second sentence, sorry. 😅
Is this the correct target branch? Do I need to do anything else or can I just merge it?

@bishabosha
Copy link
Member

You can merge this, I was saying if you don't want to wait there is a stable documentation branch

@bishabosha bishabosha merged commit 9d78307 into scala:main Oct 18, 2024
28 checks passed
@bishabosha bishabosha deleted the betterFors-docs branch October 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants