Skip to content

Conversation

@choplin
Copy link
Contributor

@choplin choplin commented Nov 25, 2025

Description

Update scalardb-analytics-sample to support ScalarDB Analytics 3.17.

Related issues and/or PRs

N/A

Changes made

  • Update ScalarDB Analytics version from 3.16.2 to 3.17.0
    • Docker images: scalardb-analytics-server-without-licensing, scalardb-analytics-cli
    • Spark package: scalardb-analytics-spark-all-3.5_2.12
  • Adapt to CLI command syntax changes for data-source register
    • Use new options: --catalog, --data-source, --provider-file
  • Update data source configuration file format
    • postgres.json: Simplified structure, changed type from postgres to postgresql
    • scalardb.json: Simplified structure, use configs with file reference
  • Update server configuration property name
    • scalar.db.analytics.server.db.urlscalar.db.analytics.server.db.contact_points
  • Adjust Docker volume mounts
    • Move scalardb.properties mount from server/spark to CLI container
  • Improve Spark Dockerfile download script

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

This is a sample project update to align with ScalarDB Analytics 3.17 release.

@choplin choplin marked this pull request as ready for review November 25, 2025 09:44
Copilot AI review requested due to automatic review settings November 25, 2025 09:44
Copilot finished reviewing on behalf of choplin November 25, 2025 09:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the scalardb-analytics-sample project to support ScalarDB Analytics version 3.17.0, adapting to API changes in the CLI commands, configuration file formats, and property naming conventions introduced in this version.

  • Docker images and Spark package upgraded from 3.16.2 to 3.17.0
  • CLI command syntax updated to use new --catalog, --data-source, and --provider-file options
  • Data source configuration files simplified with flatter structure and type naming changes (postgrespostgresql)
  • Server configuration property renamed from db.url to db.contact_points
  • Docker volume mounts adjusted to place scalardb.properties in CLI container only
  • Spark Dockerfile download script improved with better variable usage

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docker-compose.yml Updates Docker image versions to 3.17.0 and relocates scalardb.properties volume mount from server/spark to CLI container
config/scalardb-analytics-server.properties Renames server database property from db.url to db.contact_points
config/spark-defaults.conf Updates Spark package version to 3.17.0
config/data-sources/postgres.json Simplifies data source configuration structure and changes type from postgres to postgresql
config/data-sources/scalardb.json Simplifies configuration to use flattened structure with configs field referencing properties file
README.md Updates CLI command examples to use new syntax with --catalog, --data-source, and --provider-file options
docker/Dockerfile.spark Improves download script with better variable naming and proper quoting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@choplin choplin self-assigned this Nov 25, 2025
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 20ab7f2 into main Nov 26, 2025
38 checks passed
@feeblefakie feeblefakie deleted the scalardb-analytics-3.17 branch November 26, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants