Minor fixes to unit tests

[brfrn169]

Description

This PR makes small adjustments to the unit tests.

Related issues and/or PRs

N/A

Changes made

Added inline comments. Please take a look for the details.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on making minor but impactful adjustments to existing unit tests. The changes include refactoring a nested test class for better structure or warning suppression, and significantly improving the robustness of an exception assertion by handling the order of suppressed exceptions more gracefully. These updates contribute to the overall stability and maintainability of the test suite.

Highlights

• Test Class Refactoring: In CoordinatorGroupCommitterTest.java, the CoordinatorGroupCommitKeyManipulatorTest nested class has been refactored by removing its static modifier and adding a @SuppressWarnings("ClassCanBeStatic") annotation. This change likely addresses a specific compiler warning or enables certain test setup patterns that require the nested class to be non-static.
• Improved Exception Assertions: In ParallelExecutorTest.java, the exception assertion logic for executeTasks has been enhanced. Instead of directly using assertThatThrownBy, the test now uses catchException and an if/else block to assert the primary exception and its suppressed exceptions. This makes the test more robust by accounting for the non-deterministic order in which suppressed exceptions might be returned.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR makes minor adjustments to unit tests for improved exception handling and JUnit5 compliance.

• Refactored exception capture in ParallelExecutorTest to use catchException and assert suppressed exceptions.
• Added missing AssertJ imports (assertThat, catchException).
• Updated CoordinatorGroupCommitterTest nested class to be non-static as required by JUnit5, with a suppression for “ClassCanBeStatic” warnings.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
core/src/test/java/com/scalar/db/transaction/consensuscommit/ParallelExecutorTest.java	Refactored test to catch exceptions, assert suppressed exceptions, and added imports.
core/src/test/java/com/scalar/db/transaction/consensuscommit/CoordinatorGroupCommitterTest.java	Made nested test class non-static and suppressed “ClassCanBeStatic” warning.

[gemini-code-assist]

Code Review

The pull request includes a fix for a flaky test by handling non-deterministic exception ordering in parallel execution. I've suggested a small improvement to make the assertion more concise using AssertJ's features. Additionally, I've recommended reverting a change that makes a nested test class non-static.

[feeblefakie]

Although I left one question to understand it properly, LGTM! Thank you!

[komamitsu]

LGTM! 👍

[Torch3333]

LGTM, thank you!