Fix error handling for mutations in Cassandra

[brfrn169]

Description

This PR fixes error handling for mutations in Cassandra.

Related issues and/or PRs

N/A

Changes made

Added inline comments. Please take a look for the details.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

• Cassandra error handling done right
  • https://www.datastax.com/blog/cassandra-error-handling-done-right

Release notes

Fixed error handling for mutations in Cassandra.

[Copilot]

Pull Request Overview

This PR standardizes error handling by replacing RetriableExecutionException with ExecutionException for mutation operations in Cassandra and updates tests accordingly.

• Mutate and batch handlers now throw ExecutionException instead of RetriableExecutionException
• Corresponding test cases updated to expect ExecutionException
• Unused RetriableExecutionException imports removed

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
InsertStatementHandlerTest.java	Updated test method names and assertions to expect ExecutionException; removed unused import
BatchHandlerTest.java	Updated test assertions to expect ExecutionException; removed unused import
MutateStatementHandler.java	Switched all thrown RetriableExecutionException to ExecutionException
BatchHandler.java	Switched all thrown RetriableExecutionException to ExecutionException

Comments suppressed due to low confidence (2)

core/src/test/java/com/scalar/db/storage/cassandra/InsertStatementHandlerTest.java:366

• The test method name is missing the word "Throw". Consider renaming to handle_PutWithoutConditionGivenAndWTEWithSimpleThrown_ShouldThrowExecutionException for consistency.

  public void handle_PutWithoutConditionGivenAndWTEWithSimpleThrown_ShouldExecutionException() {

core/src/main/java/com/scalar/db/storage/cassandra/MutateStatementHandler.java:30

• The Javadoc still references ReadRepairableExecutionException, but this handler no longer throws that exception. Please remove or update this line to match the current behavior.

   * @throws ReadRepairableExecutionException if the execution partially fails, which can be

[gemini-code-assist]

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the error handling mechanism within the Cassandra storage layer. It unifies the exception types thrown during mutation operations by replacing RetriableExecutionException with the more general ExecutionException, thereby simplifying the API and standardizing how errors are propagated.

Highlights

• Unified Exception Handling: Replaced RetriableExecutionException with ExecutionException across BatchHandler and MutateStatementHandler to standardize error reporting for Cassandra mutation operations.
• Simplified Method Signatures: The handle methods in BatchHandler and MutateStatementHandler now declare ExecutionException as the primary checked exception, streamlining the API. (Note: NoMutationException is still mentioned in the Javadoc for BatchHandler's handle method, but removed from its throws clause).
• Updated Test Coverage: Corresponding unit tests in BatchHandlerTest and InsertStatementHandlerTest were adjusted to reflect the new exception type, ensuring continued correctness of error path assertions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request refactors error handling for Cassandra mutations by replacing RetriableExecutionException with ExecutionException. The changes are consistently applied, and the tests have been updated. There are a couple of suggestions to improve code clarity by updating comments that now contradict the new exception handling logic and fixing a typo in a test method name.

[Torch3333]

LGTM, thank you!

[feeblefakie]

LGTM! Thank you!

[komamitsu]

LGTM! 👍