Fix --no-header option not working for CSV exports

[inv-jishnu]

Description

Issue:
The --no-header option in the data loader CLI wasn't working correctly. When users tried to export CSV files without headers, the header row was still being included in the output.

Root Cause:
During a previous refactoring where we split up the ExportManager class, the code that checks whether to exclude headers was accidentally left out. It means this bug was introduced in the 3.16.0 version of the Data Loader.

Solution:
This PR adds back the missing header exclusion check, so the --no-header option now works as intended.

Related issues and/or PRs

NA

Changes made

• Added a check before writing the CSV header to verify whether headers should be excluded based on the export options
• Added unit tests to cover both scenarios: exports with headers included and exports with headers excluded

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

NA

Release notes

Fixed --no-header option being ignored in data loader CSV exports

[gemini-code-assist]

Summary of Changes

Hello @inv-jishnu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the data loader CLI where the option to exclude CSV headers during data export was not functioning as intended. The fix involves a targeted code change to ensure the header is only written when explicitly required, complemented by new unit tests to validate the corrected behavior for both header inclusion and exclusion.

Highlights

• Bug Fix: Resolved an issue where the --no-header option in the data loader CLI's CSV export functionality was not correctly excluding the header row from the output file, leading to unintended header inclusion.
• Conditional Logic Update: Implemented a conditional check within the processHeader method of CsvExportManager.java to prevent the CSV header from being written to the output file when the excludeHeaderRow option is enabled.
• Enhanced Test Coverage: Added new unit tests in CsvExportManagerTest.java to explicitly verify the correct behavior of CSV exports, covering both scenarios where the header is expected to be included and excluded. A new helper method, runExportAndAssertFirstLine, was introduced to streamline these tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where the --no-header option was not working for CSV exports. Unit tests cover both header inclusion and exclusion. The review includes suggestions to enhance the robustness and readability of the new test code, and a minor efficiency improvement in the core logic.

[ypeckstadt]

@inv-jishnu What is the status for this PR? I just noticed now it was never put back in review mode again? Is this fix still required?

If so, please mark it as open for review.

[komamitsu]

LGTM! 👍

[brfrn169]

LGTM! Thank you!

[ypeckstadt]

LGTM. Thank you.

[Torch3333]

LGTM, thank you!

[feeblefakie]

LGTM! Thank you!