Fix to use getter to get object names

[KodaiD]

Description

This PR fixes the test to use a getter to retrieve the object name. This fix addresses on omission from the following PR:

#2908

Related issues and/or PRs

#2908

Changes made

Fix to use getter to get TABLE1 and COL_NAME2 in DistributedStorageAdminIntegrationTestBase

Checklist

• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation to reflect the changes.
• I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
• Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
• Tests (unit, integration, etc.) have been added for the changes.
• My changes generate no new warnings.
• Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

[gemini-code-assist]

Summary of Changes

Hello @KodaiD, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've opened this pull request to address a minor omission from a previous change, ensuring consistency and adherence to best practices within our test suite. The primary goal is to refactor specific test cases in DistributedStorageAdminIntegrationTestBase to utilize getter methods for retrieving object names like table and column names, rather than directly accessing static constants. This change improves the robustness and maintainability of our integration tests by aligning them with proper encapsulation principles.

Highlights

• Test Code Refinement: Updated createIndex_ForNonExistingColumn_ShouldThrowIllegalArgumentException to use getTable1() instead of TABLE1 for retrieving the table name.
• Test Code Refinement: Modified dropIndex_ForNonExistingTable_ShouldThrowIllegalArgumentException to use getColumnName2() instead of COL_NAME2 for retrieving the column name.
• Test Code Refinement: Changed dropIndex_ForNonExistingIndex_ShouldThrowIllegalArgumentException to use getTable1() and getColumnName2() instead of TABLE1 and COL_NAME2 respectively.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly replaces direct access to constants like TABLE1 and COL_NAME2 with their corresponding getter methods (getTable1(), getColumnName2()) in DistributedStorageAdminIntegrationTestBase. This change improves consistency and maintainability of the test suite by adhering to the intended pattern of using getters, which allows for easier extension and overriding in subclasses. The changes are clean, targeted, and successfully address the omission from the previous refactoring. The changes look good.

[brfrn169]

LGTM! Thank you!