Skip to content

Fix to use getter to get object names #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

Fix to use getter to get object names #2931

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c364f6
Fix to use getter to get object names
KodaiD Aug 1, 2025
d17215d
Merge branch 'master' into fix-to-use-getter-in-tests
brfrn169 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...tion-test/src/main/java/com/scalar/db/api/DistributedStorageAdminIntegrationTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,8 @@ public void createIndex_ForNonExistingColumn_ShouldThrowIllegalArgumentException
// Act Assert
assertThatThrownBy(
() ->
admin.createIndex(namespace1, TABLE1, "non-existing_column", getCreationOptions()))
admin.createIndex(
namespace1, getTable1(), "non-existing_column", getCreationOptions()))
.isInstanceOf(IllegalArgumentException.class);
}

Expand Down Expand Up @@ -906,7 +907,7 @@ public void dropIndex_ForNonExistingTable_ShouldThrowIllegalArgumentException()
// Arrange

// Act Assert
assertThatThrownBy(() -> admin.dropIndex(namespace1, "non-existing-table", COL_NAME2))
assertThatThrownBy(() -> admin.dropIndex(namespace1, "non-existing-table", getColumnName2()))
.isInstanceOf(IllegalArgumentException.class);
}

Expand All @@ -915,7 +916,7 @@ public void dropIndex_ForNonExistingIndex_ShouldThrowIllegalArgumentException()
// Arrange

// Act Assert
assertThatThrownBy(() -> admin.dropIndex(namespace1, TABLE1, COL_NAME2))
assertThatThrownBy(() -> admin.dropIndex(namespace1, getTable1(), getColumnName2()))
.isInstanceOf(IllegalArgumentException.class);
}

Expand Down