-
Notifications
You must be signed in to change notification settings - Fork 40
Use CoreError for messages of UnsupportedOperationException in Cassandra adapter #3019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes error messaging for TIMESTAMP type unsupported operations in the Cassandra adapter by introducing a centralized CoreError enum value and replacing hardcoded error messages.
- Introduces
CASSANDRA_TIMESTAMP_TYPE_NOT_SUPPORTEDerror constant inCoreError - Updates three classes to use the centralized error message instead of hardcoded strings
- Maintains consistent error formatting with column name parameter
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CoreError.java | Added new error constant for Cassandra TIMESTAMP type unsupported operation |
| ValueBinder.java | Updated to use CoreError for TIMESTAMP column binding exception |
| ResultInterpreter.java | Updated to use CoreError for TIMESTAMP column conversion exception |
| CassandraAdmin.java | Updated to use CoreError for TIMESTAMP column creation and modification exceptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary of ChangesHello @brfrn169, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the error handling within the Cassandra adapter by standardizing the messages for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a good improvement. It refactors the Cassandra adapter to use a centralized CoreError for UnsupportedOperationException when handling the TIMESTAMP data type. This change enhances maintainability and consistency. The new error messages are also more informative as they now include the column name, which is helpful for debugging. The implementation is clean and correct across all modified files.
Torch3333
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
KodaiD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
josh-wong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!🙇🏻♂️
Description
This PR updates the Cassandra adapter to use
CoreErrorfor messages ofUnsupportedOperationException.Related issues and/or PRs
Changes made
CoreErrorfor messages ofUnsupportedOperationException.Checklist
Additional notes (optional)
N/A
Release notes
N/A