Skip to content

Use CoreError for messages of UnsupportedOperationException in Cassandra adapter #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

Use CoreError for messages of UnsupportedOperationException in Cassandra adapter #3019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e02d827
Use CoreError for message of UnsupportedOperationException in Cassand…
brfrn169 Sep 19, 2025
881f8d9
Merge branch 'master' into use-CoreError-in-cassandra
brfrn169 Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/java/com/scalar/db/common/CoreError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,6 +736,12 @@ public enum CoreError implements ScalarDbError {
"The BOOLEAN type is not supported for index columns in DynamoDB. Column: %s",
"",
""),
CASSANDRA_TIMESTAMP_TYPE_NOT_SUPPORTED(
Category.USER_ERROR,
"0227",
"The TIMESTAMP type is not supported in Cassandra. Column: %s",
"",
""),

//
// Errors for the concurrency error category
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/com/scalar/db/storage/cassandra/CassandraAdmin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public void createTable(
for (String column : metadata.getColumnNames()) {
if (metadata.getColumnDataTypes().get(column).equals(DataType.TIMESTAMP)) {
throw new UnsupportedOperationException(
"The TIMESTAMP data type is not supported in Cassandra. column: " + column);
CoreError.CASSANDRA_TIMESTAMP_TYPE_NOT_SUPPORTED.buildMessage(column));
}
}
try {
Expand Down Expand Up @@ -394,7 +394,7 @@ public void addNewColumnToTable(
throws ExecutionException {
if (columnType == DataType.TIMESTAMP) {
throw new UnsupportedOperationException(
"The TIMESTAMP data type is not supported in Cassandra. column: " + columnName);
CoreError.CASSANDRA_TIMESTAMP_TYPE_NOT_SUPPORTED.buildMessage(columnName));
}
try {
String alterTableQuery =
Expand Down
3 changes: 2 additions & 1 deletion core/src/main/java/com/scalar/db/storage/cassandra/ResultInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.datastax.driver.core.Row;
import com.scalar.db.api.Result;
import com.scalar.db.api.TableMetadata;
import com.scalar.db.common.CoreError;
import com.scalar.db.common.ResultImpl;
import com.scalar.db.io.BigIntColumn;
import com.scalar.db.io.BlobColumn;
Expand Down Expand Up @@ -86,7 +87,7 @@ private Column<?> convert(Row row, String name, DataType type) {
: TimeColumn.of(name, LocalTime.ofNanoOfDay(row.getTime(name)));
case TIMESTAMP:
throw new UnsupportedOperationException(
"The TIMESTAMP type is not supported with Cassandra.");
CoreError.CASSANDRA_TIMESTAMP_TYPE_NOT_SUPPORTED.buildMessage(name));
case TIMESTAMPTZ:
return row.isNull(name)
? TimestampTZColumn.ofNull(name)
Expand Down
4 changes: 3 additions & 1 deletion core/src/main/java/com/scalar/db/storage/cassandra/ValueBinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import static com.google.common.base.Preconditions.checkNotNull;

import com.datastax.driver.core.BoundStatement;
import com.scalar.db.common.CoreError;
import com.scalar.db.io.BigIntColumn;
import com.scalar.db.io.BlobColumn;
import com.scalar.db.io.BooleanColumn;
Expand Down Expand Up @@ -134,7 +135,8 @@ public void visit(TimeColumn column) {

@Override
public void visit(TimestampColumn column) {
throw new UnsupportedOperationException("The TIMESTAMP type is not supported with Cassandra");
throw new UnsupportedOperationException(
CoreError.CASSANDRA_TIMESTAMP_TYPE_NOT_SUPPORTED.buildMessage(column.getName()));
}

@Override
Expand Down