Skip to content

Conversation

@KodaiD
Copy link
Contributor

@KodaiD KodaiD commented Oct 21, 2025

Description

This PR fixes some integration test cases to enable tests for TIMESTAMPTZ.

Related issues and/or PRs

N/A

Changes made

  • Updated integration test cases to enable tests for TIMESTAMPTZ.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@KodaiD KodaiD self-assigned this Oct 21, 2025
@KodaiD
Copy link
Contributor Author

KodaiD commented Oct 21, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors several integration tests to unconditionally include TIMESTAMPTZ columns, which is a good change to improve test coverage for this data type. The changes are mostly correct and consistently applied. However, I found a critical copy-paste error in one test file where an incorrect column name is used when setting a TIMESTAMPTZ value. This will likely lead to test failures and should be corrected.

@KodaiD
Copy link
Contributor Author

KodaiD commented Oct 21, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates several integration tests to unconditionally include the TIMESTAMPTZ data type, which helps improve test coverage for this feature. The changes involve swapping the c11 and c12 columns' data types and making the TIMESTAMPTZ column (c11) a non-conditional part of the test schemas. The modifications are applied consistently across all relevant test files and their corresponding assertions. The code changes look good and achieve the stated goal.

@KodaiD KodaiD marked this pull request as ready for review October 21, 2025 09:40
Copilot AI review requested due to automatic review settings October 21, 2025 09:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors integration tests to properly separate TIMESTAMPTZ testing from conditional timestamp support checks. The key change moves TIMESTAMPTZ column definitions and operations outside the isTimestampTypeSupported() conditional blocks, enabling these tests to run independently of TIMESTAMP support.

Key Changes:

  • Moved TIMESTAMPTZ column (c11) definitions and operations outside conditional blocks
  • Moved TIMESTAMP column (c12) definitions and operations inside conditional blocks
  • Updated test assertions to align with the new column arrangement

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
DistributedTransactionAdminIntegrationTestBase.java Restructured column definitions to test TIMESTAMPTZ independently of TIMESTAMP support
DistributedStorageAdminIntegrationTestBase.java Restructured column definitions to test TIMESTAMPTZ independently of TIMESTAMP support
JdbcTransactionAdminIntegrationTest.java Restructured column definitions to test TIMESTAMPTZ independently of TIMESTAMP support
SingleCrudOperationTransactionAdminIntegrationTestWithJdbcDatabase.java Restructured column definitions to test TIMESTAMPTZ independently of TIMESTAMP support
JdbcAdminIntegrationTest.java Restructured column definitions to test TIMESTAMPTZ independently of TIMESTAMP support
JdbcAdminCaseSensitivityIntegrationTest.java Restructured column definitions to test TIMESTAMPTZ independently of TIMESTAMP support
ConsensusCommitAdminIntegrationTestWithJdbcDatabase.java Restructured column definitions to test TIMESTAMPTZ independently of TIMESTAMP support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@KodaiD KodaiD requested review from a team, Torch3333, brfrn169, feeblefakie and komamitsu and removed request for a team October 21, 2025 09:43
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment not directly related to this PR, but LGTM! 👍

Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit de34b99 into master Oct 23, 2025
170 of 172 checks passed
@brfrn169 brfrn169 deleted the fix-to-enable-tests-for-timestamptz branch October 23, 2025 06:13
feeblefakie pushed a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants