-
Notifications
You must be signed in to change notification settings - Fork 40
Add integration tests for Cassandra 4 and 5 #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to add support for Cassandra 4.1 and 5.0 by updating the Cassandra driver version and adding integration tests for the new versions. However, there is a critical issue with the Maven group ID change that will prevent the build from working.
Key changes:
- Updates cassandra-driver-core from version 3.11.5 to 3.12.1
- Changes Maven group ID from
com.datastax.cassandratoorg.apache.cassandra(this is incorrect) - Adds CI integration test workflows for Cassandra 4.1 and 5.0
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| core/build.gradle | Updates Cassandra driver dependency with incorrect Maven group ID change |
| build.gradle | Updates cassandra driver version to 3.12.1 |
| .github/workflows/ci.yaml | Adds integration test jobs for Cassandra 4.1 and 5.0 with appropriate configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
komamitsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
brfrn169
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
|
@Torch3333 Can you change the title and release note as follows since we don't know if we support 4 and 5. We will decide based on bencharking results? |
|
@Torch3333 (cc: @brfrn169 ) Since I am able to do it, I updated the title, the description, and the release note text. |
feeblefakie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR adds integration tests for Cassandra 4 and 5. These versions are backward compatible with the version 3 of the driver we have been using so far. This permits us to add support without code modifications.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
Add integration tests for Cassandra 4 and 5.