Skip to content

Conversation

@Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Nov 12, 2025

Description

This PR adds integration tests for Cassandra 4 and 5. These versions are backward compatible with the version 3 of the driver we have been using so far. This permits us to add support without code modifications.

Related issues and/or PRs

N/A

Changes made

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

Add integration tests for Cassandra 4 and 5.

@Torch3333 Torch3333 self-assigned this Nov 12, 2025
@Torch3333 Torch3333 added the enhancement New feature or request label Nov 12, 2025
@Torch3333 Torch3333 marked this pull request as ready for review November 12, 2025 06:34
@Torch3333 Torch3333 requested review from a team, brfrn169, Copilot, feeblefakie and komamitsu and removed request for a team November 12, 2025 06:34
Copilot finished reviewing on behalf of Torch3333 November 12, 2025 06:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to add support for Cassandra 4.1 and 5.0 by updating the Cassandra driver version and adding integration tests for the new versions. However, there is a critical issue with the Maven group ID change that will prevent the build from working.

Key changes:

  • Updates cassandra-driver-core from version 3.11.5 to 3.12.1
  • Changes Maven group ID from com.datastax.cassandra to org.apache.cassandra (this is incorrect)
  • Adds CI integration test workflows for Cassandra 4.1 and 5.0

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
core/build.gradle Updates Cassandra driver dependency with incorrect Maven group ID change
build.gradle Updates cassandra driver version to 3.12.1
.github/workflows/ci.yaml Adds integration test jobs for Cassandra 4.1 and 5.0 with appropriate configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie
Copy link
Contributor

feeblefakie commented Nov 13, 2025

@Torch3333 Can you change the title and release note as follows since we don't know if we support 4 and 5. We will decide based on bencharking results?

Add integration tests for Cassandra 4 and 5.

@feeblefakie feeblefakie changed the title Support Cassandra 4 and 5 Add integration tests for Cassandra 4 and 5 Nov 13, 2025
@feeblefakie
Copy link
Contributor

@Torch3333 (cc: @brfrn169 ) Since I am able to do it, I updated the title, the description, and the release note text.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants