🥅(CLDSRV-779) Manage error on putBucketReplication properly

[DarkIsDude]

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?

Related issues

Please use the following link syntaxes #600 to reference issues in the
current repository

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

[bert-e]

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-779 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.1.6

• 9.2.0

Please check the Fix Version/s of CLDSRV-779, or the target
branch of this pull request.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (7fcf5d8) to head (b872051).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Files with missing lines	Coverage Δ
...api/apiUtils/bucket/getReplicationConfiguration.js	92.30% <100.00%> (+1.39%)	⬆️

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.0    #5996      +/-   ##
===================================================
+ Coverage            83.37%   83.40%   +0.03%     
===================================================
  Files                  189      189              
  Lines                12197    12199       +2     
===================================================
+ Hits                 10169    10175       +6     
+ Misses                2028     2024       -4     

Flag	Coverage Δ
ceph-backend-test	65.99% <100.00%> (+0.03%)	⬆️
file-ft-tests	66.81% <100.00%> (+<0.01%)	⬆️
kmip-ft-tests	26.98% <0.00%> (-0.01%)	⬇️
mongo-v0-ft-tests	68.14% <100.00%> (+<0.01%)	⬆️
mongo-v1-ft-tests	68.13% <100.00%> (+<0.01%)	⬆️
multiple-backend	35.67% <0.00%> (-0.01%)	⬇️
quota-tests	32.25% <0.00%> (-0.04%)	⬇️
quota-tests-inflights	34.18% <0.00%> (-0.01%)	⬇️
unit	67.56% <100.00%> (+<0.01%)	⬆️
utapi-v2-tests	33.34% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-779 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.0.33

• 9.1.6

• 9.2.0

Please check the Fix Version/s of CLDSRV-779, or the target
branch of this pull request.

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

[SylvainSenechal]

Are these new tests related to your changes 🤔
You changed getReplicationConfiguration, but the tests aren't calling this function

[DarkIsDude]

Yes and no. This PR resolve a 500 errors that we have. Changes in the other PR fix an another issue. If Arsenal is merged after this one, I'll bump arsenal in an another PR to have this change as soon as possible 🙏

[francoisferrand]

I concur : would be nice to also have a unit test calling getReplicationConfiguration() in case of error...

[SylvainSenechal]

Should you add some asserts on err.response.headers ? I ask because the test is called "should return cors headers on malformed xml", but it feels more like a "should return malformedXML on malformed replication configuration" 🤔

[francoisferrand]

did you really mean to add this file?

(we don't generally have these files, maybe worth discussing before adding them here - so we also add them elsewhere... somehow also related to the discussion/analysis on coding style https://scality.atlassian.net/browse/OS-1014)