Open
Conversation
Collaborator
|
Hm. So then it looks like an error still happens, and the JS fails, but now we don't raise an exception in Ruby when it does? Am I understanding correctly? If so, I'm worried because this will stop failing on essentially all Javascript errors. That does let Ruby continue, but also masks a lot of possible problems that we won't see when they happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed the Git Hub Link that fails -> #516
This fix enhances the user experience by ensuring seamless navigation to GitHub via links. It also prevents any disruptions that users might have previously encountered due to this issue.
Video(if needed, helps for a faster review)
PR.Video.mp4
Checklist