Skip to content

Fix GitHub link #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vikas-chaudhary-2802 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix GitHub link #543

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf2dc2a
Fixing kerning para style
Feb 8, 2024
90e340c
generated fixture
Feb 8, 2024
67bdc01
fix github link
vikas-chaudhary-2802 Feb 9, 2024
0ab332e
Update Kerning.rb
vikas-chaudhary-2802 Feb 9, 2024
185b124
Delete examples/Kerning.rb
vikas-chaudhary-2802 Feb 9, 2024
66c5368
Update para.rb
vikas-chaudhary-2802 Feb 9, 2024
9d09a02
Update para.rb
vikas-chaudhary-2802 Feb 9, 2024
830fcb2
Delete test/wv/html_fixtures/Kerning.html
vikas-chaudhary-2802 Feb 9, 2024
6083b6e
Merge branch 'scarpe-team:main' into Fix_GITHUB_LINK
vikas-chaudhary-2802 Feb 9, 2024
b85dd9a
Update font_family.html
vikas-chaudhary-2802 Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/scarpe/wv/web_wrangler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,10 +690,17 @@ def promise_redraw

@log.debug("Redraw is now fully up-to-date") if fully_updated?
end.on_rejected do
@log.error "Could not complete JS redraw! #{promise.reason.full_message}"
@log.debug("REDRAW FULLY UP TO DATE BUT JS FAILED") if fully_updated?
begin

rescue Scarpe::JSRuntimeError => e
@log.error "JS runtime error: #{e.full_message}"
rescue Scarpe::JSRedrawError => e
@log.error "JS Redraw failed: #{e.full_message}"
end
# @log.error "Could not complete JS redraw! #{promise.reason.full_message}"
# @log.debug("REDRAW FULLY UP TO DATE BUT JS FAILED") if fully_updated?

raise Scarpe::JSRedrawError, "JS Redraw failed! Bailing!"
# raise Scarpe::JSRedrawError, "JS Redraw failed! Bailing!"

# Later we should figure out how to handle this. Clear the promises and queues and request another redraw?
end
Expand Down