Skip to content

Always call bar.Finish() in Reader #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schollz merged 1 commit into from
Dec 26, 2025
Merged

Always call bar.Finish() in Reader #218

schollz merged 1 commit into from
Dec 26, 2025

Conversation

@mrkbac
Copy link
Contributor

@mrkbac mrkbac commented May 16, 2025

In the current implementation, bar.Finish() is never called if the underlying io.Reader also implements io.Closer.

@schollz schollz merged commit f13fb15 into schollz:main Dec 26, 2025
1 check passed
@sh4869221b sh4869221b mentioned this pull request Dec 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrkbac @schollz