-
Notifications
You must be signed in to change notification settings - Fork 2
chore: drop Python 3.9, add timeouts, fix test passing logic #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks @ariostas! I was gonna do that today since we dropped py3.9 in coffea main yesterday |
|
@pfackeldey since you have more experience with |
|
I am aware of this syntax but this still runs into the problem Probably just cloning in ci, run |
|
@henryiii is there a way to get awkward-cpp from main without cloning? Should there be a way if that's not the case? Can this |
|
I think we could trigger that via cmake instead of via nox, then it would be possible. |
This is what I tried doing here, but I'm not sure why it's not working. integration-tests/.github/workflows/test_awkward_dask-awkward_uproot_coffea_vector.yml Lines 103 to 107 in 0879e2c
|
ci right now shows failures in the "Save results to file" step, not installation. You can also use |
|
Uhmmm @ariostas in the last ci run, the windows py3.13 tests failed but I do not see a single actual test failure in the logs |
ikrommyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
|
Awesome! thanks for doing this! |
@pfackeldey Yeah, that's right. You can see that it happened in the latest run: https://github.com/scikit-hep/integration-tests/actions/runs/19680002339 . So before making a release maybe it's still worth checking the summary of the nightly run and making sure that the dask-awkward row is not all Xs. I guess one simple alternative would be to check that there's no more than, say, 3 Xs in the table, and fail the job otherwise. Btw, Iason and I were wondering if you know which of the tests are the flaky ones. We've seen one very flaky and one less flaky one. One option could be to exclude only those and make the rest required (maybe even upstream?). |
This PR drops testing on Python 3.9, adds timeout to tests to make sure they don't get stuck, adds retries to dask-awkward tests, and fixes the logic to determine if all tests passed.