Skip to content

Conversation

@andrzejnovak
Copy link
Member

Add comprehensive support for flow parameter in comparison plotting functions
including plot_data_model_comparison(), plot_two_hist_comparison(), and
plot_model(). Key improvements:

  • Preserve original histogram flow information through plotting pipeline
  • Pass original histograms to histplot() for proper flow bin detection
  • Prevent xlim reset when flow="show" to preserve extended axis range
  • Filter 'flow' parameter before passing to funcplot() compatibility
  • Add flow-aware ratio computation in comparison panels

Supports all flow options: "hint" (diamond markers), "show" (extended range),
"sum" (included in edge bins), and "none".

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

andrzejnovak and others added 2 commits November 25, 2025 21:23
- Resolved duplicate [tool.pixi.workspace] sections that were causing redefinition errors
- Restored configuration from main branch to maintain consistency
- Keep main branch's pixi setup for proper environment management
@andrzejnovak
Copy link
Member Author

@copilot maybe you can fix this to stop breaking the other tests

Copy link
Contributor

Copilot AI commented Nov 26, 2025

@andrzejnovak I've opened a new pull request, #659, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants