-
Notifications
You must be signed in to change notification settings - Fork 71
fix: prevent duplicate flow hint markers on comparison axes #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
4
commits into
flowfix
Choose a base branch
from
copilot/sub-pr-657
base: flowfix
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: andrzejnovak <[email protected]>
Copilot
AI
changed the title
[WIP] Add flow parameter support in comparison plotters
fix: prevent duplicate flow hint markers on comparison axes
Nov 26, 2025
Copilot finished work on behalf of
andrzejnovak
November 26, 2025 00:56
Member
|
@copilot make sure the tests pass and you are committing the updated baseline images where relevant |
Co-authored-by: andrzejnovak <[email protected]>
Contributor
Author
Copilot finished work on behalf of
andrzejnovak
November 26, 2025 07:51
Member
|
@copilot We have a few issues still:
|
Co-authored-by: andrzejnovak <[email protected]>
Contributor
Author
Fixed in 20d25ea. Reverted the unrelated baseline image changes:
The remaining baseline changes are only for the 1d comparison tests and test_issue_594 which are directly affected by the flow hint marker fix. |
Copilot finished work on behalf of
andrzejnovak
November 26, 2025 08:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.