feat: add more MC lhe files for pylhe

[APN-Pucky]

We want to add a few lhe{,.gz} files for pylhe tests scikit-hep/pylhe#291:

• madgraph
• powheg
• sherpa
• pythia
• herwig (does not export to lhe)
• whizard

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.38%. Comparing base (5e54716) to head (0a36f0d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #180   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files           3        3           
  Lines         134      134           
=======================================
  Hits           97       97           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[eduardo-rodrigues]

Great to see this.

A little question while I approve: are these all files that you produced yourself or should one be adding a README or some other citation in case you copied the files over from somewhere? We had a similar discussion in #67 and ended up adding a .doi file in that particular case.

[APN-Pucky]

A little question while I approve: are these all files that you produced yourself or should one be adding a README or some other citation in case you copied the files over from somewhere? We had a similar discussion in #67 and ended up adding a .doi file in that particular case.

whizard, sherpa, pythia-8.3.14 and madgraph5-3.5.X I ran myself. The remaining files I took from pythias example folder: https://gitlab.com/Pythia8/releases/-/tree/master/examples?ref_type=heads

[eduardo-rodrigues]

OK, cool. Then maybe add a my_file_name.readme for those files, stating inside that the file is taken from the link above (latest tag sounds good, since a clear point in time)?

Please merge when happy 👍.

[APN-Pucky]

I added the readme, but the pre-commit hook removed tailing newlines and trailing spaces so it is not easy to verify files by checksums anymore... Just in case somebody wonders in the future why they are slightly different. (IMO there should be no such pre-commit for the data folder)

[eduardo-rodrigues]

I added the readme, but the pre-commit hook removed tailing newlines and trailing spaces so it is not easy to verify files by checksums anymore... Just in case somebody wonders in the future why they are slightly different. (IMO there should be no such pre-commit for the data folder)

Ah, I had not seen that. Fair enough one should ignore the data folder ... Or else filter on file types, as in the block https://github.com/scikit-hep/particle/blob/main/.pre-commit-config.yaml#L21.

[APN-Pucky]

Please merge when happy 👍.

Who can merge it? I do not have access to scikit-hep-testdata. Can we get a new release then too, because I want to add the files in pylhe to the tests too.

[eduardo-rodrigues]

Hey, I'm presently at a conference. Can you email the list to get somebody to merge and release? Else I will try later, but you probably want to proceed. Thanks.

[ariostas]

I can merge and make a release. Do you want to fix the issue with pre-commit first, or just merge as is?

[APN-Pucky]

Thanks @ariostas. Since it is probably better, I will update the pre-commit and then recopy the files so that the hashes agree again.

[APN-Pucky]

@ariostas I excluded .lhe (and .lhe.gz, which is maybe not strictly needed) from the precommit now and it can be merged, IMO.

[ariostas]

Sounds good, thanks @APN-Pucky! I'll merge and make a release now.